Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add meta descriptions to top-level pages #12239

Merged
merged 2 commits into from
Dec 20, 2024
Merged

docs: add meta descriptions to top-level pages #12239

merged 2 commits into from
Dec 20, 2024
+6 −1

Conversation

Meschreiber
Copy link
Contributor

@Meschreiber Meschreiber commented Dec 19, 2024 •
edited
Loading

Add meta descriptions and subtitles to help with discoverability

@Meschreiber Meschreiber requested a review from a team as a code owner December 19, 2024 23:49
@svc-apollo-docs
Copy link

svc-apollo-docs commented Dec 19, 2024 •
edited
Loading

✅ Docs Preview Ready

Configuration 
{
  "repoOverrides": {
    "apollographql/apollo-client@main": {
      "remote": {
        "owner": "apollographql",
        "repo": "apollo-client",
        "branch": "docs/add-meta-descriptions-to-key-pages"
      }
    }
  }
}
Name Link

Commit

5688802

Preview

https://www.apollographql.com/docs/deploy-preview/ab11f62c6946d7931e42

Build ID

ab11f62c6946d7931e42

File Changes
0 new, 3 changed, 0 removed 
* (developer-tools)/react/(latest)/get-started.mdx
* (developer-tools)/react/(latest)/index.mdx
* (developer-tools)/react/(latest)/why-apollo.mdx

Pages

3

3 pages published. Build will be available for 30 days.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 5688802

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 19, 2024 

npm i https://pkg.pr.new/@apollo/client@12239

commit: 5688802

@netlify Netlify
Copy link

netlify bot commented Dec 19, 2024

✅ Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 5688802
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/6764b129163f7e000888485a
😎 Deploy Preview https://deploy-preview-12239--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.66 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 50.07 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.18 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.18 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.58 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.29 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.7 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.41 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.35 KB (0%)
import { useFragment } from "dist/react/index.js" 2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.31 KB (0%)

@phryneas phryneas merged commit 6dcb6ba into main Dec 20, 2024
47 of 48 checks passed
@github-actions github-actions bot added the auto-cleanup 🤖 label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phryneas phryneas phryneas approved these changes

Assignees
No one assigned
Labels
auto-cleanup 🤖
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Meschreiber @svc-apollo-docs @phryneas